Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MessageRunMode usage #362

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix MessageRunMode usage #362

merged 3 commits into from
Oct 9, 2024

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Sep 26, 2024 •
edited
Loading

Part of NIT-2812

This PR:

  • adds MessageRunMode parameter to ApplyTransactionWithResultFilter, so it can be called with different modes

  • changes mode used in StateProcessor.Process from MessageCommitMode to MessageReplayMode

@cla-bot cla-bot bot added the s CLA signed label Sep 26, 2024
@magicxyyz magicxyyz mentioned this pull request Sep 26, 2024
Merged
tsahee
tsahee approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 54adef6 into master Oct 9, 2024
6 checks passed
@tsahee tsahee deleted the fix-run-mode branch October 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@diegoximenes diegoximenes diegoximenes approved these changes

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @diegoximenes @tsahee